Skip to content

Summary aliasing of search fields #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

esoteric-ephemera
Copy link
Contributor

@esoteric-ephemera esoteric-ephemera commented Apr 10, 2025

Major changes:

  • SummaryRester: Allows for searching by nelements rather than num_elements, as nelements is the top-level field in the returned SummaryDoc. Both kwargs are still supported, but a deprecation warning is thrown if num_elements is specified
  • Tests

Copy link
Member

@tschaume tschaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esoteric-ephemera! The get_stability function looks good and I think it would be good to release it. Would you mind separating the get_stability and the nelements updates into their separate PRs?

@esoteric-ephemera esoteric-ephemera changed the title Summary aliasing of search fields + revive get_stability function Summary aliasing of search fields Apr 10, 2025
@tschaume
Copy link
Member

Closing this as we're looking into potentially solving this for all low-level query parameters available in the API.

@tschaume tschaume closed this Apr 14, 2025
@shyuep shyuep reopened this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants